feat: add Claude Code plugin support#4575
Conversation
🦋 Changeset detectedLatest commit: 4cbac8f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![hyperspace-insights[bot]](https://avatars.githubusercontent.com/u/2531208?s=60&v=4){kind=small}
There was a problem hiding this comment.
The PR is well-structured and achieves its goal of adding Claude Code plugin support cleanly. The two issues flagged are: a minor inaccuracy in the AGENTS.md documentation describing the homepage field, and a missing error-handling block in the sync script that could produce cryptic CI failures if any manifest file is absent or malformed.
PR Bot Information
Version: 1.20.11 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback
This comment was marked as duplicate.
This comment was marked as duplicate.
heimwege
left a comment
heimwege
left a comment
There was a problem hiding this comment.
Just one nit-pick comment.
heimwege
left a comment
heimwege
left a comment
There was a problem hiding this comment.
- review comments addressed
- changeset ok
- coverage ok
- did NOT test manually
|
New proposal to move the plugin out of the MCP server to a more generic plugin like "plugins/SAP-Fiori-tools" |
vinayhospete
dismissed
their stale review
New proposal to move plugin out of MCP server
Klaus-Keller
left a comment
Klaus-Keller
left a comment
There was a problem hiding this comment.
Thanks @mustafamengutay-sap!
Files and adjustments to publish MCP server as Claude plugin look good.
If we have more than one plugin this makes sense. For one I'd say we keep it together with the sources and document the files as we've done. |
|
5 participants
This PR registers the Fiori MCP Server as a plugin in the Claude Code plugin registry for enabling users to find and install it directly from within Claude Code.
Changes
Adds
plugin.json, the Claude Code plugin registry manifest. Defines the plugin name, description, author, homepage, repository, license, keywords, and version so the server appears in Claude Code's plugin discovery UI.Adds
.mcp.jsonat the package root. This file is automatically picked up by Claude Code when the plugin is enabled, starting the MCP server via npx.Adds
AGENTS.mddocumenting the purpose ofserver.json,plugin.json,.mcp.json, or AI coding agents and contributors working on this package.Extends
sync-mcp-manifests.js(formerlysync-mcp-server-json.js), so all manifest files stay in sync automatically after changeset version bumps via the CI pipeline.